Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change lib dependencies to private #3

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: change lib dependencies to private #3

merged 1 commit into from
May 8, 2024

Conversation

justforlxz
Copy link
Member

Dependencies do not have to be propagated

Log:

@justforlxz justforlxz requested a review from wineee May 8, 2024 06:48
@justforlxz
fix: change lib dependencies to private
2f4b1df 
Dependencies do not have to be propagated

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 修改了common目标链接库的属性从PUBLIC到PRIVATE，可能会影响依赖关系。

是否建议立即修改:

  • 是，需要确认修改后的依赖关系是否符合项目的构建策略和需求。如果项目中的其他目标依赖于common的目标，那么这个修改可能会导致链接错误。需要评估这个改动的影响范围，并确保修改是基于准确的依赖关系。如果这个改动是有意为之，还需要确保所有相关的文档和配置都已经更新，以反映这一变化。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit 667c572 into linuxdeepin:master May 8, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wineee wineee wineee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justforlxz @deepin-ci-robot @wineee